Fix close button active box misalignment #3443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
Hello @raclim, |
|
Thanks so much for your work on this! Since we generally try to work with PRs that were submitted first, we ultimately went with #3439 since it also had a viable solution that was suggested from the original issue. However, I think the solution you provided here was a great alternative as well, and I really appreciate that you added in screenshots of how it looked! I'm sorry that we couldn't get this one in, but please feel free to check out our other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3434
Changes:
client/styles/components/_overlay.scssto center thesvginside buttonThis also ensures that the all other places (such as share overlay) where close button is used is also fixed.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123